Skip to content

Trashbin followup fixes#37633

Merged
skjnldsv merged 4 commits into
masterfrom
fix/trashbin
Apr 11, 2023
Merged

Trashbin followup fixes#37633
skjnldsv merged 4 commits into
masterfrom
fix/trashbin

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Apr 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member
  1. Fix action store update (deleting/restore updates the list automatically, it was missing an update of the @nextcloud/files library)
  2. Fix trashbin download filename header
  3. Fix breadcrumbs displayname
    image
  4. Fix loading state when executing multiple actions:
    • When executing a single action on a row of a selected file, the batch actions should temporarily be disabled
    • When executing an action on a selection, the individual action be disabled
1 2
Peek 07-04-2023 09-29 Peek 07-04-2023 09-30

Reference #37627 #36534

There is some php to review too 😉 @icewind1991

@skjnldsv skjnldsv self-assigned this Apr 7, 2023
@skjnldsv
skjnldsv requested review from a team, Pytal, artonge and szaimen and removed request for a team April 7, 2023 07:43
@skjnldsv
skjnldsv requested a review from icewind1991 April 7, 2023 07:43
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 7, 2023
View reviewed changes
Comment thread apps/files_trashbin/lib/Sabre/TrashbinPlugin.php Fixed
@skjnldsv
skjnldsv force-pushed the fix/trashbin branch 2 times, most recently from 1dc96a9 to 61d66bf Compare April 7, 2023 12:46
@skjnldsv

This comment was marked as resolved.

Sign in to view
Pytal
Pytal approved these changes Apr 10, 2023
View reviewed changes
Comment thread apps/files/src/store/files.ts
szaimen
szaimen approved these changes Apr 11, 2023
View reviewed changes

@szaimen szaimen left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works but didnt review the code

artonge
artonge approved these changes Apr 11, 2023
View reviewed changes
Comment thread apps/files/src/components/FilesListHeaderActions.vue
skjnldsv added 4 commits April 11, 2023 11:56
@skjnldsv
fix(files): update @nextcloud/files and fix event store update
e3f575b 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(files_trashbin): set real filename on trashbin download
441aab6 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(files): fix private variables and share loading marker between he…
45f39d6 
…ader and row

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(files): use displayName in breadcrumbs if available
0b0dbb9 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 11, 2023
@skjnldsv
skjnldsv merged commit c6645cb into master Apr 11, 2023
@skjnldsv
skjnldsv deleted the fix/trashbin branch April 11, 2023 10:28
@joshtrichards joshtrichards mentioned this pull request Jul 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes
@Pytal Pytal Pytal approved these changes
@szaimen szaimen szaimen approved these changes
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files feature: trashbin

Projects

Files to vue
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @artonge @Pytal @szaimen @github-advanced-security